Fix array_exprt handling in incremental SMT2 procedure#8778
Open
tautschnig wants to merge 1 commit intodiffblue:developfrom
Open
Fix array_exprt handling in incremental SMT2 procedure#8778tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8778 +/- ##
========================================
Coverage 80.01% 80.01%
========================================
Files 1700 1700
Lines 188344 188345 +1
Branches 73 73
========================================
+ Hits 150701 150705 +4
+ Misses 37643 37640 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The call to `define_dependent_functions` ensures that `array_exprt` expressions are properly handled and their dependent functions are defined before the expression conversion process begins. Fixes: diffblue#8080
tautschnig
force-pushed
the
fix-8080-inc-smt-array
branch
from
7365b9a to
8d7fbd5
Compare
There was a problem hiding this comment.
Pull request overview
Fixes incremental SMT2 expression conversion for array_exprt by ensuring dependent functions are defined before converting expressions, and updates an existing regression test to exercise the incremental SMT2 path.
Changes:
- Call
define_dependent_functions(expr)at the start ofconvert_expr_to_smt. - Update an existing CBMC regression test configuration to no longer exclude the “new SMT” path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/solvers/smt2_incremental/smt2_incremental_decision_procedure.cpp | Defines dependent functions before expression substitution/conversion to properly handle array_exprt. |
| regression/cbmc/array-cell-sensitivity12/test_execution.desc | Removes no-new-smt to ensure the regression runs against the incremental SMT2 workflow impacted by this fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to
define_dependent_functionsensures thatarray_exprtexpressions are properly handled and their dependent functions are defined before the expression conversion process begins.Fixes: #8080